fix: more spacing in edit preferences form #9097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #9097 +/- ##
==========================================
+ Coverage 47.85% 47.95% +0.10%
==========================================
Files 64 64
Lines 19965 20013 +48
Branches 4833 4850 +17
==========================================
+ Hits 9554 9597 +43
- Misses 9163 9168 +5
Partials 1248 1248 see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
As Stephane said it's an improvement but unrelated to the issue. Can you take care of fixing the original issue too in this PR? And by the way margin-bottom is also missing below the "Close" button:
|
raphael0202
reviewed
Oct 5, 2023
html/js/product-preferences.js
Outdated
| @@ -222,10 +223,12 @@ function display_user_product_preferences(target_selected, target_selection_form | |||
| checked = ' checked'; | |||
| } | |||
|
|
|||
| attribute_group_html += "<div class='attribute_item'>" | |||
There was a problem hiding this comment.
Couldn't you add it below instead of adding a new attribute_group_html += ?
|
Kudos, SonarCloud Quality Gate passed!
|
raphael0202
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7492
What
Add 1rem of margin bottom to close button and "Classify products according to your preferences"
Screenshot
Related issue(s) and discussion
@raphael0202